Skip to content

Bugfix invite members modal

James Rushford requested to merge 403736-invite-modal-doesn-t-open-in-the-create-menu into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Invite Members modal was not working because the menu item that was being rendered was a haml partial. Fix included:

  • passing component name to menu group items when available
  • not passing href when not available (so as to render a button rather than a link)
  • using slots to control the render of groups and items within GlDisclosureDropdown so that InviteMembersTrigger could be used for Inviting members
  • updating InviteMembersTrigger to be useful for GlDisclosureDropdownItem

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

before after
Screen_Recording_2023-04-13_at_17.43.50 Screen_Recording_2023-04-13_at_16.17.46

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #403736 (closed)

Edited by James Rushford

Merge request reports