Skip to content

Disable creating Approval Required Todo for all MR approvers

Alan (Maciej) Paruszewski requested to merge 324988-disable-todos-for-mr-approvals into master

What does this MR do and why?

This MR disables creating APPROVAL_REQUIRED todos that are automatically created when Approval Rules are configured. With this change and after feature flag is enabled

How to set up and validate locally

  1. Enable feature flag
  2. Create a project
  3. Create approval rules (https://docs.gitlab.com/ee/user/project/merge_requests/approvals/rules.html#merge-request-approval-rules) for the project (or Scan Result Policies (https://docs.gitlab.com/ee/user/application_security/policies/scan-result-policies.html)) and invite some members
  4. Create new MR that will require approval
  5. Login as one of the defined memebers
  6. Verify that you do not have Todo created

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #324988 (closed)

Merge request reports