Skip to content

Align dropdowns within the super sidebar

Paul Gascou-Vaillancourt requested to merge 390930-dropdowns-position into master

What does this MR do and why?

This applies the necessary left offset to the "Create" and user menus in the super sidebar for the dropdowns to be aligned with the sidebar instead of floating to the right.

Additionally, this hides the "Create" menu's tooltip when it is opened. Until now, the tooltip would stay visible as long as the menu is open.

Known caveat

It's possible for the user menu to overflow the super sidebar when it contains a long status. This could also happen when using GitLab in non-English languages. We'll be providing an option to limit the width in gitlab-ui#2209 (closed).

Screenshots or screen recordings

Menu Before After
"Create" Screenshot_2023-04-14_at_2.53.02_PM Screenshot_2023-04-14_at_2.51.09_PM
User Screenshot_2023-04-14_at_2.55.00_PM Screenshot_2023-04-14_at_2.51.19_PM

How to set up and validate locally

  1. Enable the new nav:
    1. Enable the feature flag:

      echo "Feature.enable(:super_sidebar_nav)" | rails c
    2. Enable the user setting from the user dropdown:

      Screenshot_2022-12-13_at_1.32.43_PM

  2. Open the "Create" or user menu.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #390930 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading