Skip to content

Fix for notification toggle not working on issue's task modal

Rajan Mistry requested to merge 389444-fix-work-items-notifications-modal-issue into master

What does this MR do and why?

The toggle is not working in production if it is accessed from a task modal of an issue.
Use v-model so that the toggle works for task modal. Moreover, add a test case to check both toggle scenario.

Screen recordings

Before After
Screen_Recording_2023-04-18_at_11.28.46_AM Screen_Recording_2023-04-18_at_11.29.53_AM

How to set up and validate locally

Prerequisites: Enable the following feature flags to create objects supporting this feature using gdk rails console:

  1. Feature.enable(:work_items_mvc)
  2. Feature.enable(:work_items_mvc_2)
  3. Feature.enable(:okrs_mvc, Project.find_by_full_path('gitlab-org/gitlab-test'))

Steps to check with modal:

  1. Go to any Project > Issues > List
  2. Create an Issue
  3. Go to Issue detail page > Tasks section
  4. Add a Task
  5. Click on the newly added item
  6. Click on the right top kebab menu to see the Notification toggle
  7. Use the toggle to turn on or turn off the notifications

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389444 (closed)

Edited by Rajan Mistry

Merge request reports