Skip to content

Cleanup removed files from RuboCop TODOs and rspec_order_todo.yml

Peter Leitzen requested to merge pl-cleanup-removed-files into master

What does this MR do and why?

This commit removes excludes from RuboCop TODOs and rspec_order_todo.yml for removed/non-existent files.

Done via https://gitlab.com/-/snippets/2482940.

Follow-up of !108680 (merged).

How to set up and validate locally

# Check diff
git diff HEAD~

# Collect files removed
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)' | sort | uniq

# Check if they still exist via `stat`
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)'  | sort | uniq | xargs stat -c "%n" {} 2>/dev/null
# No output

# Verify by touching a removed file
touch ee/spec/views/layouts/_search.html.haml_spec.rb

# Run again
git diff HEAD~ | rg -r '$1' -o '^-\s+- (\S+)'  | sort | uniq | xargs stat -c "%n" {} 2>/dev/null
ee/spec/views/layouts/_search.html.haml_spec.rb

Git stats

 .rubocop_todo/capybara/visibility_matcher.yml      |   3 -
 .../database/disable_referential_integrity.yml     |   1 -
 .rubocop_todo/database/rescue_query_canceled.yml   |   1 -
 .rubocop_todo/fips/sha1.yml                        |   8 -
 .rubocop_todo/gitlab/namespaced_class.yml          |   4 -
 .rubocop_todo/gitlab/strong_memoize_attr.yml       |   4 -
 .rubocop_todo/layout/argument_alignment.yml        |  47 ----
 .rubocop_todo/layout/array_alignment.yml           |   2 -
 .../layout/empty_line_after_magic_comment.yml      |  34 ---
 .../layout/first_hash_element_indentation.yml      |   3 -
 .rubocop_todo/layout/line_continuation_spacing.yml |   3 -
 .../line_end_string_concatenation_indentation.yml  |   2 -
 .rubocop_todo/layout/line_length.yml               | 243 ------------------
 .rubocop_todo/layout/parameter_alignment.yml       |   6 -
 .rubocop_todo/layout/space_in_lambda_literal.yml   |   4 -
 .rubocop_todo/layout/space_inside_parens.yml       |   3 -
 .rubocop_todo/layout/trailing_whitespace.yml       |   1 -
 .../lint/ambiguous_operator_precedence.yml         |   2 -
 .rubocop_todo/lint/ambiguous_regexp_literal.yml    |   2 -
 .rubocop_todo/lint/empty_block.yml                 |   1 -
 .../lint/missing_cop_enable_directive.yml          |  14 --
 .../lint/redundant_cop_disable_directive.yml       |   9 -
 .rubocop_todo/lint/symbol_conversion.yml           |   2 -
 .rubocop_todo/lint/unused_block_argument.yml       |   6 -
 .rubocop_todo/lint/unused_method_argument.yml      |   8 -
 .rubocop_todo/metrics/cyclomatic_complexity.yml    |   1 -
 .rubocop_todo/metrics/perceived_complexity.yml     |   1 -
 .../migration/background_migration_base_class.yml  |  33 ---
 .../migration/background_migration_record.yml      |  22 --
 .rubocop_todo/migration/background_migrations.yml  |  32 ---
 .rubocop_todo/naming/heredoc_delimiter_naming.yml  |   9 -
 .rubocop_todo/performance/map_compact.yml          |   1 -
 .rubocop_todo/rails/file_path.yml                  |   2 -
 .rubocop_todo/rails/inverse_of.yml                 |   1 -
 .rubocop_todo/rails/pluck.yml                      |   1 -
 .rubocop_todo/rails/redundant_foreign_key.yml      |   5 -
 .rubocop_todo/rspec/context_wording.yml            |  26 --
 .rubocop_todo/rspec/described_class.yml            |   2 -
 .rubocop_todo/rspec/expect_change.yml              |  10 -
 .rubocop_todo/rspec/expect_in_hook.yml             |   3 -
 .rubocop_todo/rspec/factory_bot/avoid_create.yml   |   5 -
 .rubocop_todo/rspec/file_path.yml                  |   1 -
 .rubocop_todo/rspec/hooks_before_examples.yml      |   5 -
 .rubocop_todo/rspec/instance_variable.yml          |   4 -
 .rubocop_todo/rspec/missing_feature_category.yml   |  80 ------
 .rubocop_todo/rspec/multiple_memoized_helpers.yml  |   2 -
 .../rspec/repeated_example_group_description.yml   |   2 -
 .rubocop_todo/rspec/return_from_stub.yml           |   3 -
 .rubocop_todo/rspec/scattered_let.yml              |   1 -
 .rubocop_todo/rspec/shared_groups_metadata.yml     |   1 -
 .rubocop_todo/rspec/verified_doubles.yml           |   5 -
 .rubocop_todo/style/class_and_module_children.yml  |   8 -
 .rubocop_todo/style/empty_method.yml               |   6 -
 .rubocop_todo/style/format_string.yml              |   3 -
 .rubocop_todo/style/guard_clause.yml               |   6 -
 .rubocop_todo/style/hash_as_last_array_item.yml    |   1 -
 .rubocop_todo/style/if_unless_modifier.yml         |   9 -
 .rubocop_todo/style/keyword_parameters_order.yml   |   1 -
 .rubocop_todo/style/numeric_literal_prefix.yml     |   5 -
 .rubocop_todo/style/percent_literal_delimiters.yml |   8 -
 .rubocop_todo/style/redundant_freeze.yml           |   4 -
 .rubocop_todo/style/redundant_self.yml             |   8 -
 .rubocop_todo/style/single_argument_dig.yml        |   1 -
 .rubocop_todo/style/string_concatenation.yml       |   2 -
 .../style/string_literals_in_interpolation.yml     |   3 -
 .rubocop_todo/style/symbol_proc.yml                |   6 -
 spec/support/rspec_order_todo.yml                  | 274 ---------------------
 67 files changed, 1016 deletions(-)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports