Skip to content

Refactor ConvertTableToFirstListPartition

Simon Tomlinson requested to merge list-partitioning-helper-fix-fks/refactor into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR refactors the ConvertTableToFirstListPartiton class to a List::ConvertTable class with the same functionality.

It splits the locking configuration from List::ConvertTable to a new List::LockingConfiguration class, and splits the spec setup code to spec/support/shared_contexts/lib/gitlab/database/partitioning/list_partitioning_shared_context.rb so that both of these can be reused in a future MR that adds support for redefining foreign keys after the conversion.

The refactor here will lead to Draft: Queue replacement foreign keys during pa... (!118096), which uses the extracted functionality.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Simon Tomlinson

Merge request reports