Skip to content

Adds link to settings on container registry image list page

What does this MR do and why?

To increase discoverability of settings, adds a link from Project > Packages and registries > Container registry to Project > Settings > Packages and registries

Expected

  • Container Registry will only show button at project level as container registry settings are only available at project
  • Settings button should not show for users who are developer or below (and thus cannot see the settings)
  • Navigating to the settings from the feature page opens the corresponding section in the settings.

Screenshots or screen recordings

container registry list page as project maintainer/owner/admin

Screenshot_2023-04-20_at_9.42.55_pm

How to set up and validate locally

  1. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md

  2. In the terminal, run these commands to push images to test base repository & sub repository

    $ docker pull hello-world
    $ docker tag hello-world 127.0.0.1:5000/<project-path> && docker push 127.0.0.1:5000/<project-path>
    $ docker tag hello-world 127.0.0.1:5000/<project-path>/testing && docker push 127.0.0.1:5000/<project-path>/testing
    $ docker tag hello-world 127.0.0.1:5000/<project-path>/testing/hello-world && docker push 127.0.0.1:5000/<project-path>/testing/hello-world
  3. Visit Project > Packages and registries > Container registry - Link should point to project settings

  4. View same page as user without permission & should be not be able to view link

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #368989 (closed)

Edited by Rahul Chanila

Merge request reports

Loading