Fix padding on new nav search lists
requested to merge 404644-frequent-items-edit-mode-delete-button-overlaps-with-long-item-names into master
What does this MR do and why?
Describe in detail what your merge request does and why.
Increases the right padding on Nav Item Project and Group titles so that it does not overlap with the remove button.
Screenshots or screen recordings
Before | After | |
---|---|---|
not edit mode | ||
project edit mode while hovering | ||
group edit mode while hovering | ||
search mode |
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- In order to force a long name to test, within
app/assets/javascripts/super_sidebar/utils.js
changeformatContextSwitcherItems
on line 76 to be the following:
export const formatContextSwitcherItems = (items) =>
items.map(({ id, name: title, namespace, avatarUrl: avatar, webUrl: link }) => ({
id,
title: 'long long test title very long',
subtitle: 'subtitle long long test title very long',
avatar,
link,
}));
- Open the context Switcher within the super sidebar
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #404644 (closed)
Edited by James Rushford