Add back MR widget changes to support fail-closed approval rules
What does this MR do and why?
This MR brings back the MR widget adaptions from !117423 (merged) that were reverted in !118140 (merged) due to issue #408161 (closed).
The issue was caused by an inconsistent backend response that is addressed by !118189 (merged).
Screenshots or screen recordings
In addition to the screenshots in the original MR, here are screenshots of the problematic any_approver
rule:
Before the backend fix is applied:
After the backend fix is applied:
Combination of various rules with disabled FF invalid_scan_result_policy_prevents_merge
:
Combination of various rules with enabled FF invalid_scan_result_policy_prevents_merge
:
When approval is given and action is still required:
With a merge rule with single approver:
How to set up and validate locally
See the original MR !117423 (merged).
In addition, you can enforce any_approver
rule:
- In project settings -> Merge requests, set
Approvals required
to 1 forAll eligible users
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #389905 (closed)