Skip to content

Move merge base pipeline logic to EE

Brian Williams requested to merge bwill/move-merge-base-check-to-ee into master

What does this MR do and why?

Describe in detail what your merge request does and why.

::Ci::CompareMetricsReportsService, ::Ci::CompareCodequalityReportsService, and ::Ci::CompareSecurityReportsService are all EE classes. Since use_merge_base_pipeline_for_comparison? is related to those classes specifically, it should be in EE. This change moves the code to the EE file. To lower the risk of EE class usage happening the in the CE file in the future, we use constants instead of strings for the map keys. This means that trying to reference an EE constant inside CE will cause an undefined constant error and fail the pipeline when running FOSS-impact tests.

This is a follow-up for !117594 (comment 1359161344).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brian Williams

Merge request reports