Skip to content

Add user abuse metadata fields to spamcheck gRPC requests

Ian Anderson requested to merge user-abuse-metadata into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds user abuse metadata fields to the spamcheck gRPC requests. These fields will be used to further enhance ML models by training on user features in addition to the spammable text. Training on these features may have applications outside of spamcheck by providing a generalized value for user trust.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run the spamcheck service locally 
    docker run --rm -p 8001:8001 registry.gitlab.com/gitlab-org/gl-security/security-engineering/security-automation/spam/spamcheck:1.7.1
  2. Enable spamcheck in your local GDK instance by navigating to admin/application_settings/reporting.
    • Enable spamcheck
    • Set the URL of the external Spam Check endpoint to grpc://localhost:8001 image
  3. As a regular user (impersonate a non-admin) attempt to create an issue in a public project (i.e. gitlab-org/gitlab-test).
  4. You should see logs from the spamcheck service that the issue was checked for spam. There should not be any errors in the spamcheck service logs.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports