Skip to content

Refactor trial create lead into service

Doug Stull requested to merge 393969-simplify-current-new-trial-creation-methods-create into master

What does this MR do and why?

  • creates a service to handle business logic
  • refactors the controller for create_lead to use it.

A lot of work was done via !115895 (merged) to ensure we are covered by tests in ee/spec/features/trials/saas/

Doing this to move the business logic and complexity out of the controller layer in hopes to make the controller a little easier to reason about and maintain.

This was broken off from a much larger/full-picture MR !115567 (merged).

Full picture for final state can be seen as part of !115567 (merged) and by looking at the plan in #393969 (closed)

Screenshots or screen recordings

no change.

How to set up and validate locally

note basically trying to emulate feature spec steps in ee/spec/features/trials/saas/creation_with_one_existing_namespace_flow_spec.rb

  1. Setup to simulate SaaS and restart GDK
  2. Create a new group.
  3. Visit trials new path as in http://gdk.test:3000/-/trials/new.
  4. Fill out the form...
  5. The rest would be really hard to emulate here w/o a fully setup local customersDot and is why we have the feature specs that haven't needed to change with this MR.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393969 (closed)

Edited by Doug Stull

Merge request reports