Skip to content

RuboCop: Remove redundant inline disables

Peter Leitzen requested to merge pl-rubocop-remove-inline-disables into master

What does this MR do and why?

This MR removes redundant inline disables for 👮 rules RSpec/MultipleMemoizedHelpers and Lint/BinaryOperatorWithIdenticalOperands.

In both cases, we saw the cops being disabled via Exclude directives (TODO or permanent) and via rubocop:disable inline.

This combination causes problems when upgrading to RuboCop 1.50.2. See !118399 (closed)

🔴 https://gitlab.com/gitlab-org/gitlab/-/jobs/4158439380

How to set up and validate locally

bundle exec rubocop --parallel --only Lint/BinaryOperatorWithIdenticalOperands,RSpec/MultipleMemoizedHelpers
# no offenses

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports