Skip to content

Resolve "Fix focus states on shortcuts"

James Rushford requested to merge 404859-fix-focus-states-on-shortcuts into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Make use of gl-focus--focus so that counter buttons work exactly the same as links. Also had to remove box-shadow: none; for focus as gl-focus--focus uses a border-box to show focus.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

before after
recording Screen_Recording_2023-04-28_at_11.46.30 Screen_Recording_2023-04-28_at_11.45.58
screenshot with all manually focused Screenshot_2023-04-28_at_11.34.37 Screenshot_2023-04-28_at_11.21.18
Screenshot_2023-05-02_at_09.52.53 Screenshot_2023-05-02_at_09.53.56
Screenshot_2023-05-02_at_09.53.04 Screenshot_2023-05-02_at_09.54.12
Screenshot_2023-05-02_at_09.53.09 Screenshot_2023-05-02_at_09.54.19
Screenshot_2023-05-02_at_09.53.14 Screenshot_2023-05-02_at_09.54.23

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #404859 (closed)

Edited by James Rushford

Merge request reports

Loading