Skip to content

Resolve "Fix focus transition from search to avatar"

What does this MR do and why?

Describe in detail what your merge request does and why.

Fixes the transition for :active on buttons by using gl-button instead of button on user menu

Screenshots or screen recordings

before after
transition Screen_Recording_2023-04-26_at_15.36.27 Screen_Recording_2023-04-26_at_15.36.03
user menu unselected (should be no change) Screenshot_2023-04-26_at_15.37.11 Screenshot_2023-04-26_at_15.37.43
user menu selected (should be no change) Screenshot_2023-04-26_at_15.46.49 Screenshot_2023-04-26_at_15.45.39

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

If you also want to test with impersonation icon and GitLab Next item as is in the recording (optional):

  1. Follow steps to impersonate user: https://docs.gitlab.com/ee/user/admin_area/#user-impersonation
  2. To force GitLab Next item, change app/assets/javascripts/super_sidebar/components/user_bar.vue#L119 to be v-if="true"

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #404858 (closed)

Edited by James Rushford

Merge request reports

Loading