Improve danger's project_factory_suggestion

What does this MR do and why?

Improve the let_it_be suggestion made by danger by indicating that it could leak states between tests, and contributors should feel comfortable ignoring this suggestion if let or let! are the better options.

This partially addresses the abuse of let_it_be which resulted in Multiple spec failures with error PG::QueryCanc... (#402915 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.