Skip to content

Refactor quick actions service

euko requested to merge 328734-refactor-quick-actions-service into master

What does this MR do and why?

This MR contains a minor (almost cosmetic) refactor of Notes::QuickActionsService. There is no behavioral change.

Notes::QuickActionsService accepts a note containing quick actions and passes them to the note's noteable's update service.

As an example, a note for an issue (noteable) might say "/assign foobar". Notes::QuickActionsService understands the assign command. Notes::QuickActionsService builds its update parameter { assignee: foobar } then executes Issues::UpdateService with the update parameter.

During the review of !112543 (comment 1294240094), it was noted that we'd be better off directly checking and calling each noteable's update service to make the code easier to follow and understand. This MR implements the suggested refactor.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by euko

Merge request reports