Super sidebar menu section button aria-expanded
What does this MR do and why?
Add aria-expanded
to the <button>
in menu_section.vue
to provide audible feedback to screen-readers that a toggle button is expanded or not when reading through menu items.
Chnages
- Remove
<section>
elements from menu - Restore
aria-expanded
attribute on menu section buttons - Restore
aria-controls
attribute on menu section buttons - Restore
gl-mb-1
on menu section buttons - Add tests for
aria-controls
andaria-expanded
attributes
Screenshots or screen recordings
Before | After |
---|---|
CleanShot_2023-04-28_at_15.43.22 | CleanShot_2023-04-28_at_15.42.02 |
How to set up and validate locally
- Enable super sidebar (if not currently on)
- In
rails c
enable feature flagFeature.enable(:super_sidebar_nav)
- Toggle on "new navigation" in user menu
- In
- Toggle menu section with screen-reader
- Review spacing between nav items
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #408938 (closed)