Resolve whitespace in super sidebar on search page
What does this MR do and why?
Add v-if="menuItems.length"
condition to <sidebar-menu>
rendering to remove empty HTML elements being rendered, adding whitespace to the UI
<nav class="gl-p-2 gl-relative">
<!----> <!---->
<ul class="gl-p-0 gl-list-style-none"></ul>
</nav>
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Enable super sidebar (if not currently on)
- In
rails c
enable feature flagFeature.enable(:super_sidebar_nav)
- Toggle on "new navigation" in user menu
- In
- Go to
/search
there should no longer be space before contents loaded in<sidebar-portal-target />
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.