Skip to content

Calculate board height in CSS

Simon Knox requested to merge psi-boards-height into master

What does this MR do and why?

Clean up board height calculation to be "use all available space", rather than a bunch of calculations.
Previously it was using ResizeObserver in JS, which was expensive and timingout lots (spamming sentry with errors), and buggy when resizing sometimes.

Screenshot_2023-05-08_at_22.28.51

We also had a bunch of rules using $issue-boards-filter-height, which was not always correct – either with visible scrollbar on filter bar, or when items wrapped.

Also only show x scrollbar when needed (auto instead of scroll) to give slightly more vertical space when possible.

No visual changes otherwise:

Screen_Recording_2023-05-02_at_19.25.40

issue board swimlanes epic board header / footer
Screenshot_2023-05-02_at_19.00.09 Screenshot_2023-05-02_at_18.59.20 Screenshot_2023-05-02_at_19.11.38 Screenshot_2023-05-02_at_18.58.54

How to set up and validate locally

For both Issue boards & Epic boards, test a range of sizes (mobile / desktop /

  1. Check lists are full height of the page
  2. Test boards in Focus Mode (click icon at top right of board)
  3. Add system footer/header (Admin > Settings > Appearance)
  4. (issue boards only) Enable swimlanes and check scrolling still works (then whole page scrolls, headers stick)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Simon Knox

Merge request reports

Loading