Artifacts page: Handle case where project statistics is null
What does this MR do and why?
Link to error in sentry (internal link)
In certain circumstances (such as when the user is not logged in), the result of a project statistics GraphQL query may not even have a statistics
object. This MR handles that case by returning buildArtifactsSize
as null
so that we don't throw an error, and it adds a test for this case that would've failed before.
Screenshots or screen recordings
before | with this MR |
---|---|
no unhandled console errors |
How to set up and validate locally
git checkout master
- in a private browsing window, open your browser's devtools Console tab
- navigate to a project and choose
CI/CD
=>Artifacts
in the sidebar - an error about
buildArtifactsSize
appears in the devtools Console tab git checkout artifacts-page-handle-when-project-statistics-is-null
- refresh the artifacts page
- the error should be gone
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miranda Fluharty