Skip to content

Handle build.runner being nil when constructing JWT

Alishan Ladhani requested to merge ali/handle-build-runner-being-nil-in-jwt into master

What does this MR do and why?

Fixes a regression introduced in !116867 (merged). Changelog is not added because the regression was introduced in the same release.

Related to #409621 (closed)

Screenshots or screen recordings

Pending job:

Screenshot_2023-05-03_at_2.52.44_PM

Before fix (signed out):

Screenshot_2023-05-03_at_2.53.14_PM

After fix (signed out):

Screenshot_2023-05-03_at_2.54.47_PM

How to set up and validate locally

  1. Create a pending job (e.g. by adding a tag to the job so it doesn't get picked up)
  2. Open the trace while logged out (add /trace.json to the path)
  3. Check that the status for the request is 204 and not 500

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alishan Ladhani

Merge request reports

Loading