Do not show cloud licensing banner when subscription is already on cloud
This addresses #385768 (closed).
What does this MR do and why?
This MR changes the logic of displaying the cloud licensing banner do show it only when the user is under a legacy license. Please refer to the parent issue for details on why we're doing this.
Screenshots or screen recordings
Before:
After:
How to set up and validate locally
- Checkout this branch
- Set
export GITLAB_LICENSE_MODE=test
, and ensureGITLAB_SIMULATE_SAAS
is not set to truthy value (unset GITLAB_SIMULATE_SAAS
) - Start GDK
- Navigate to
<GDK URL>/admin/subscription
- Add a cloud activation code
- Verify banner is not displayed
- Remove the license
- Navigate to
<GDK URL>/admin/application_settings/general
- Scroll to "Add License"
- Add a legacy license
- Verify the banner is displayed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Paulo Barros