Skip to content

Update right sidebar top position for MR sidebar on small screens

Scott de Jonge requested to merge bugfix-right-sidebar-top into master

What does this MR do and why?

Update right sidebar top position for MR sidebar on small screens

  • Update top position for .right-sidebar-merge-requests to include --top-bar-height
  • Maintain existing top position for .right-sidebar:not(.right-sidebar-merge-requests)
  • Remove padding-right moving MR review bar action buttons when .right-sidebar-expanded

Screenshots or screen recordings

Before After
127.0.0.1_3000_flightjs_Flight_-merge_requests_4_iPhone_SE___1 127.0.0.1_3000_flightjs_Flight_-merge_requests_4_iPhone_SE___2
Mobile Desktop
127.0.0.1_3000_flightjs_Flight_-merge_requests_4_iPhone_SE___2 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__3

How to set up and validate locally

Note: this assumes you have the moved MR sidebar with Feature.enable(:moved_mr_sidebar), otherwise there will be no change see screenshots below:

Mobile Desktop
127.0.0.1_3000_flightjs_Flight_-merge_requests_4_iPhone_SE___3 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading