Add wait_for_all_requests after click_button in feature tests
What does this MR do and why?
Describe in detail what your merge request does and why.
Related #385304 (closed)
Follow-up !118193 (merged)
We want to improve flaky issues, mainly the ones with flaky-testunreliable dom selector. Tests that sometimes give a timeout. We noticed that we are fixing flaky tests by adding wait_for_all_requests
#384518 (closed) #385660 (closed)
In this MR we:
- Add
wait_for_all_requests
after click_button. - This surfaced flaky tests, false positives and those tests are now quarantined.
From Capybara documentation https://github.com/teamcapybara/capybara#asynchronous-javascript-ajax-and-friends
Methods are called right after the visit returns.
Capybara waits upon failed predicates/assertions.
It our cases there are elements that we were checking in pages that were not loading yet. After adding wait_for_all_requests
elements are loading and checks are failing.
Quarantine
After we merge this the folwing should be marked as quarantine
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.