Refactor apply trials action to use service
What does this MR do and why?
Iteratively working towards !115567 (merged)
ee/spec/features/trials/saas/
tests
- refactor apply trials action to use service, moving business logic out of the controller layer.
- fine tune
create_lead
action:- update the reason name when there is
no_single_namespace
found for clarity - remove not possible condition of
not_found
- update the reason name when there is
- rename
trial eligible
related method names around thenamespace
wording as that is where the scope is defined. - clarify the
namespace
assignment in the service layer and be explicit about the use.
Screenshots or screen recordings
no change.
How to set up and validate locally
note basically trying to emulate feature spec steps in ee/spec/features/trials/saas/*
- Setup to simulate SaaS and restart GDK
- Create 2 new groups.
- Visit trials new path as in
http://gdk.test:3000/-/trials/new
. - Fill out the form...
- The rest would be really hard to emulate here w/o a fully setup local customersDot and is why we have the feature specs that haven't needed to change with this MR.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393969 (closed)
Edited by Doug Stull