Skip to content

Fixes a comment form bug in the diffs app

Phil Hughes requested to merge ph/diffsVirtualScrollerBugFixes into master

What does this MR do and why?

This merge request fixes a few bugs within the diffs virtual scroller:

  • Fixes a bug the comment form would sometimes randomly scroll the diffs app around. This can be caused by the virtual scroller removing elements from the DOM and then re-adding them causing the mounted autofocus method call to happen when it shouldn't
  • Removes a JS error with the ResizeObserver
  • Fixes a bug where collapsed files would incorrectly get loaded when scrolling the diffs app
  • Fixes a bug where the spacing between diff files would sometimes disappear when scrolling fast

Fixes a comment form bug in the diffs app

This fixes a bug in the diffs virtual scroller where the comment form would get autofocused when the virtual scroller removes and then re-adds the diff file component into the DOM.

Fixes a bug where the virtual scroller would incorrectly load a collapse file on scroll.

Fixes a bug where sometimes the diff files would have no space between them when scrolling fast.

Related Issues:

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kai Armstrong

Merge request reports

Loading