Skip to content

Remove stickyness from Diff Stats Header

Lukas Eipert requested to merge leipert-less-sticky-is-the-better-sticky into master

What does this MR do and why?

Remove stickyness from Diff Stats Header

This removes the stickyness from the files diff header on:

  • Groups Wiki Diff
  • Projects Wiki Diff
  • Projects Compare page
  • Projects Commit page

The Merge Request view used to have this behaviour as well, but doesn't seem to exhibit any longer.

Changelog: changed

Fix syntax highlighting on Wiki Diff pages

This fixes the syntax highlighting on Wiki Diff pages (Group and Project).

Changelog: fixed

Screenshots or screen recordings

Before After
Screen_Recording_2023-05-05_at_16.23.18 Screen_Recording_2023-05-05_at_16.27.24

Note: For me in Firefox, the exactness of scrolling is off on a soft page-reload, but a hard page reload scrolls to the right line

How to set up and validate locally

  1. Go to any commit page, that is a little longer, e.g. /flightjs/Flight/-/commit/f79dbdf2e88a3699bc8020076695a04d856f2463#9732849daca6ae818696d9575f5d1207d1a7f8bb_318_320
  2. Go to any compare page, which is a little longer, e.g. /flightjs/Flight/-/compare/v1.3.0...v1.4.0?from_project_id=6&straight=false#b82ec1e0b3efe512fd2f31e20a45d6e5ee0796a6_24_24
  3. Wiki is a little tricky:
    1. Create or find a wiki and create a page with some hundred line changes
    2. Click "Page history"
    3. In the table click the entry inside the "Changes" column and NOT the "Page version" column

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports