Removing Ci:Bridge jobs from ProjectJob#show
What does this MR do and why?
Navigating to jobs/:id url for Ci::Bridge jobs hasn't been working for a while. https://gitlab.com/gitlab-org/gitlab/-/jobs/4214340316
This error has been around for a while, the sentry links change overtime as the method gets renamed.
From this epic comment: #345046 (comment 1047195073), this endpoint was suppose to be used for a new feature. But the new feature was terminated, removed but this code was never reverted.
I don't think the .json endpoint of #show ever worked
Screenshots or screen recordings
Instead of erroring-out, the #show endpoint will return generic 404 for Ci::Bridge jobs. As there's nothing to be displayed for them.
How to set up and validate locally
- Trigger a bridge job
- Handcraft a url for the bridge job (using job's id into
/namespace/project/-/jobs/:bridge_job_id
- Should no longer error out
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #407277 (closed)