Skip to content

Replace deprecated view_component slot setter in project pages

Thomas Hutterer requested to merge thutterer/view_component_slot_setter_3 into master

What does this MR do and why?

Updates a bunch of deprecated ViewComponent slot setter calls in /app/views/projects with the new slot setters like c.with_SLOT_NAME.

The old way (c.SLOT_NAME) got deprecated in the later 2.x versions of the view_component gem and now got completely removed in the recent 3.0 release. We have to replace all deprecated calls before we can Upgrade to view_component v3.0 (#408988 - closed).

Because we have 150+ lines in ~50 files to update, I do it in batches to get smaller, more reviewable MRs. This is one of them.

Screenshots or screen recordings

No visual changes.

How to set up and validate locally

  • I've done a search&replace-all (&👀) in /app/views/projects, so please double-check that I didn't accidentally do something stupid like with_with_foo. Thanks :)
  • We are currently on the latest 2.x version of the view_component gem. Both ways to set the slot work here, so there shouldn't be any functional changes, but feel free to browse around in the affected areas of the UI. Examples:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports

Loading