Skip to content

Add test to prevent .yaml extension

Mikołaj Wawrzyniak requested to merge mwaw/verify_that_every_metric_definition_is_using_correct_format into master

What does this MR do and why?

Recently a MR appeared that used .yaml instead of .yml file extension for metrics definition. Since it looks like using only .yml file extension is established convention among GitLab codebase, current MR adds test to prevent .yaml extension

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

mv config/metrics/counts_7d/20230112174745_i_testing_active_user_weekly.yml  config/metrics/counts_7d/20230112174745_i_testing_active_user_weekly.yaml
bin/rspec ee/spec/config/metrics/every_metric_definition_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports