Skip to content

Cleanup artefacts from notes.id bigint migration

Krasimir Angelov requested to merge 389306/notes/fix-migration-order into master

What does this MR do and why?

For couple of tables, merge_request_user_mentions and issue_user_mentions, where we had to create index and FK in advance, we have incorrect timestamps for migrations. This was OK for GitLab.com, as MRs were merged and deployed in the correct order, but could be an issue for development and test environments.

issue_user_mentions we fixed with !117476 (merged). This does the same for merge_request_user_mentions, and in addition:

  • adds some more cleanup in the migrations tests
  • fixes a typo
  • adds additional cleanup migration to drop the indexes and FKs if they exists. This could happen for development environments only.

Related to #392815 (closed).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports