Skip to content

Put elevated_guests under a feature flag

Jarka Košanová requested to merge 399119-elevated-guests-ff into master

What does this MR do and why?

This MR puts elevating_permissionsmethod of MemberRole under a feature flag. If the feature flag is disabled, the method returns an empty array.

Reasoning

We introduced read_vulnerability permission for custom roles in #399119 (closed). But that caused a performance issue. That issue was fixed in !120415 (merged) but caused a failing master. The reason is that we already have the column on the database.

This MR the performance issue without breaking the master by putting the problematic query behind a feature flag.

In future we should limit the FF for a group, but that requires deeper understanding of the query and places it is being called.

Follow-ups

FF roll-out issue: #410805 (closed)

Describe in detail what your merge request does and why.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #399119 (closed)

Edited by Jarka Košanová

Merge request reports