Skip to content

Unset environment variables set in CI but used in tests

Mark Lapierre requested to merge ml-fix-qa-env-spec into master

What does this MR do and why?

Clears QA_REMOTE_GRID* environment variables before tests that depend on them. They were deployed after https://gitlab.com/gitlab-org/quality/engineering-productivity-infrastructure/-/merge_requests/372

Fixes failures like https://gitlab.com/gitlab-org/gitlab/-/jobs/4271736793#L1647:

  1) QA::Runtime::Env.remote_grid accepts https protocol
     Failure/Error: expect(described_class.remote_grid).to eq('https://localhost:4444/wd/hub')
     
       expected: "https://localhost:4444/wd/hub"
            got: "https://gitlab-sl:[MASKED]@localhost:4444/wd/hub"
     
       (compared using ==)
     # ./spec/runtime/env_spec.rb:321:in `block (3 levels) in <top (required)>'

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mark Lapierre

Merge request reports