Skip to content

Do not return group of current project in list of transfer locations

Rutger Wessels requested to merge rw-hide-current-parent-group-project-transfer-location into master

What does this MR do and why?

Projects are connected to Groups. In the setting of a Project, we allow users to move a project to another group. The available groups are the groups that the user has access to. But it also includes the current group of the project, which makes no sense.

This MR will exclude the group of the current project from the list of other groups.

Related issue #371116 (closed)

Screenshots or screen recordings

For project 'Flight' in group 'Flightjs', http://localhost:3000/flightjs/Flight/edit

Current master: Group 'Flightjs' is available

image

This branch: Group 'Flightjs' is removed from the dropdown:

image

How to set up and validate locally

Using GitLab Development Kit and user 'root':

  1. Open a browser and go to http://localhost:3000/flightjs/Flight/edit (project 'Flight')
  2. Expand the 'Advanced' section and expand the dropdown under 'Select a new namespace'
  3. Group of project 'Flight' should not be there
  4. Transferring project 'Flight' to another group should still work

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rutger Wessels

Merge request reports