Draft: DO NOT MERGE Move full stop
What does this MR do and why?
Describe in detail what your merge request does and why.
Previously the "learn more" link correctly did not include the full stop, this introduces a bug where it does.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
before | after |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Open up the rails console
rails c
and enable theshow_overage_on_role_promotion
flag (Feature.enable(:show_overage_on_role_promotion)
) - Navigate to the project members page for a project (ex:
gitlab-org/gitlab-shell/-/project_members
) - Change the
Max role
value, the modal should appear- Clicking off of the modal or clicking "Back" should close the modal
- Clicking "Continue" will also close the modal (will be updated in a follow up)
- Clicking the "Learn more" link should open a help page in a new tab
- Open the dropdown and re-select the current
Max role
value. The modal should not appear
- Disable the feature flag (
Feature.disable(:show_overage_on_role_promotion)
) - Ensure that the modal does not appear when changing the
Max role
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #411401 (closed)