Skip to content

365 default value for `max_personal_access_token_lifetime`

Jessie Young requested to merge jy-validate-max-personal-access-token-lifetime into master

What does this MR do and why?

  • Adding default value so that new GitLab instances receive this value
  • Adding presence validations so that existing instances are still valid but new instances of ApplicationSettings cannot set this value to nil
  • We want to keep this an Ultimate-only setting but we want the 365 day limit enforced for all GitLab instances, both CE and EE.
  • Note that this setting is currently only enforced for non-Ultimate customers. So this change will only affect Ultimate customers (for now)
  • #387057 (comment 1393250676)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports