Skip to content

Clean up tofa* db columns

Jessie Young requested to merge jy-tofa-cleanup into master

What does this MR do and why?

  • This was a codename used for Vertex AI before we were ready to publicly announce this integration
  • Many of these columns contained non-sensitive data but were being used to obscure code. Those values can now safely be hard-coded. Sensitive values can remain as settings but should be renamed for clarity
  • The remaining setting with tofa in the name is tofa_url. That should receive further refactoring because the way we are handling it today is weird (there is a hard-coded URL and then we use gsub to change it for other models) so I will handle that separately.
  • Partially addresses https://gitlab.com/gitlab-org/gitlab/-/issues/408829

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jessie Young

Merge request reports

Loading