Skip to content

Fix VSA label search for large groups

Alex Pennells requested to merge 408942-max-label-suggestions into master

What does this MR do and why?

Fixes Value steam analytics label search for large groups

Adds maxSuggestions to FilteredSearchBar token config. For backwards compatibility there is no limit by default.

Implements the new option in the VSA FilterBar to improve render times in groups with many labels (ex. gitlab-org)

Screenshots

No limit Max 3 labels
Screenshot_2023-05-19_at_2.50.28_PM Screenshot_2023-05-19_at_2.50.47_PM

How to set up and validate locally

  1. Visit the VSA page for a group or project: http://gdk.test:3000/flightjs/Flight/-/value_stream_analytics
  2. Create a new Value Stream with the default template if you don't already have one created
  3. In the filter bar, select Label and view the list of available labels
  4. Reduce MAX_LABELS constant or seed new labels for the group/project
  5. Validate that the number of labels rendered matches MAX_LABELS

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #408942 (closed)

Edited by Alex Pennells

Merge request reports