TestFileFinder: Refactor tests.yml
What does this MR do and why?
This MR refactors tests.yml
:
- Always use quotes for consistency
- It's required if the value starts with
%s
anyway
- It's required if the value starts with
- Consolidate some entries by using
(ee/)?
as a prefix
Note that https://gitlab.com/gitlab-org/ci-cd/test_file_finder/-/merge_requests/30#note_1403325646 starts to use quotes as well.
It also improves failure message of scripts/verify-tff-mapping
The output is now more RSpec-like:
tff mapping verification failed:
FOSS code should map to respective spec:
Source app/finders/admin/projects_finder.r
Expected ["spec/finders/admin/projects_finder_spec.rb"]
Actual []
https://gitlab.com/gitlab-org/gitlab/-/issues/368628:
Source lib/gitlab/usage_data_counters/wiki_page_counter_spec.rb
Expected ["spec/lib/gitlab/usage_data_spec.rb", "spec/lib/gitlab/usage_data_counters/wiki_page_counter_spec.rb"]
Actual ["spec/lib/gitlab/usage_data_spec.rb"]
How to set up and validate locally
scripts/verify-tff-mapping
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Peter Leitzen