Skip to content

Skip configure Pages when set custom domain in group

Yongbo li requested to merge gitlab-jh/jh-team/gitlab:test_domain_verification_helper into master

What does this MR do and why?

Decouple Domain Verification and Pages Wizard

Somehow, If an admin does not want to use Pages, they are still forced to enable Gitlab.config.pages.external_https to enable Domin Verification.

cc @zhanglinjie @tianlu1677 relates to: #375492 (closed)

Screenshots or screen recordings

no screenshot

How to set up and validate locally

  1. simulated saas locally
export GITLAB_SIMULATE_SAAS=1

Follow the 3rd step in https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance to ensure the group is using EE plan.

  1. Upload Premium license to enable domain_verification feature
  2. enable domain_verification_operation feature in console:
Feature.enable(:domain_verification_operation)
  1. install and enable pages in gdk
  2. Visit the new domain verification page
http://localhost:3000/groups/flightjs/-/settings/domain_verification/new

it returns 404 if you are on the master branch.
You will require to Enable custom Domain to see this page

  1. checkout this branch and visit the domain_verification page again
git checkout test_domain_verification_helper
gitlab_pages:
  enabled: false

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Yongbo li

Merge request reports