Skip to content

Update getContentWrapperHeight usage in drawers

Scott de Jonge requested to merge 412976-content-wrapper-for-height-offset into master

What does this MR do and why?

!121966 (merged) adds .content-wrapper as default argument in getContentWrapperHeight so that implementations of GlDrawer with :header-height no longer need to add an argument.

Screenshots or screen recordings

Old Nav New Nav
127.0.0.1_3000_flightjs_Flight_-merge_requests_4__2 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1
127.0.0.1_3000_flightjs_Flight_-_ci_editor_branch_name_master_tab_0 127.0.0.1_3000_flightjs_Flight_-_ci_editor_branch_name_master
127.0.0.1_3000_flightjs_Flight_-ci_editor_branch_name_master_tab_0__1 127.0.0.1_3000_flightjs_Flight_-_ci_editor
127.0.0.1_3000_admin_runners_5_register_platform_linux 127.0.0.1_3000_admin_runners_4_register_platform_linux
127.0.0.1_3000_flightjs_Flight_-on_demand_scans_new__1 127.0.0.1_3000_flightjs_Flight_-_on_demand_scans_new
127.0.0.1_3000_flightjs_Flight_-security_vulnerabilities_93__1 127.0.0.1_3000_flightjs_Flight_-_security_vulnerabilities_93

How to set up and validate locally

  1. Enable system header in admin settings
  2. Toggle the performance bar with p + b
  3. View drawers
  4. Confirm top position is correct

Note: how to set up and validate drawers behind feature flags locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #412976 (closed)

Edited by Scott de Jonge

Merge request reports