Skip to content

Use `:header-height` prop for top offset in what's new drawer

Scott de Jonge requested to merge 412976-drawer-header-height-whats-new into master

What does this MR do and why?

Remove custom margin-top style overrides for What's new drawer, use getContentWrapperHeight to bind :header-height on GlDrawer. !121966 (merged) adds .content-wrapper as default argument in getContentWrapperHeight so that implementations of GlDrawer with :header-height no longer need to add an argument.

Screenshots or screen recordings

Old Nav New Nav
127.0.0.1_3000_dashboard_todos__1_ 127.0.0.1_3000_dashboard_todos

How to set up and validate locally

  1. Enable system header in admin settings
  2. Toggle the performance bar with p + b
  3. View "What's new" drawer in help menu
  4. Confirm top position is correct

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #412976 (closed)

Merge request reports

Loading