Convert the CROWD sign-in form to Pajamas
What does this MR do and why?
- Added autocomplete
usernameandcurrent-password, as recommended here: https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands - Converted the form and the submit button to Pajamas. Simplify the checkbox.
- Removed padding in each individual element by adding it to the parent form.
This is part 3 of a series of MRs to clean-up, improve and normalize the structure of the sign-in pages.
Changelog: changed
Screenshots or screen recordings
General sign-in page
| Before | After |
|---|---|
 |
 |
Admin mode
| Before | After |
|---|---|
 |
 |
The Remember me option shouldn't be displayed. We do the same for the LDAP and normal sign-ins in the Admin mode.
We renamed the Sign in button to Enter admin mode to make it consistent with the other tabs.
How to set up and validate locally
- Enable CROWD following this guide
- Play with both, new and old styles:
echo "Feature.disable(:restyle_login_page)" | gdk rails console - [Optional] Enable the Admin Mode in Admin > Settings > General > Sign-in restrictions
- On an incognito window, go to the main page: https://gdk.test:3443/admin
- [Optional] Enter the admin area: https://gdk.test:3443/admin
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Eduardo Sanz García