Skip to content

Migrate dropdown to new dropdown component

Shane Maglangit (Personal) requested to merge gitlab-community/gitlab:sm-master-patch-dropdown-migration-2 into master

What does this MR do and why?

Migrate GlDropdown to GlDisclosureDropdown or GlCollapsibleListbox

  • app/assets/javascripts/integrations/edit/components/override_dropdown.vue
  • app/assets/javascripts/environments/components/new_environment_item.vue

Screenshots or screen recordings

Before After
image image
image image

How to set up and validate locally

app/assets/javascripts/integrations/edit/components/override_dropdown.vue

  1. Go to /admin > Settings > Integrations > Asana, fill up the values and save changes.
  2. Return to / and go the project-level integration setting ({Project} > Settings > Integrations > Asana)
  3. A dropdown should be displayed on the top-right corner to switch between default and custom settings.

app/assets/javascripts/environments/components/new_environment_item.vue

Normally, we'd need to setup the environment, runners, and have pipelines run to show all these options. However, since we only changed the UI-related things and kept the functions as-is (onClick handlers and modals), we can skip this setup and just apply a patch to show all options: new_environment_dropdown_vue.patch

  1. Apply patch from the file above to new_environment_item.vue (basically, set all dropdown v-if to true).
  2. Open a project and go to Operate > Environments (Create a new environment if you don't have one yet but GDK should have this prepopulated).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Fixes #413043 (closed), #413498 (closed)

Edited by Shane Maglangit (Personal)

Merge request reports