Skip to content

Stop testing gitaly error messages in submodule update service

James Fargher requested to merge fix_update_submodule_tests into master

What does this MR do and why?

These error messages are not a specified part of the gitaly GRPC interface and so cannot be relied on. These validations already have tests in gitaly itself.

See https://gitlab.com/gitlab-org/gitaly/-/blob/master/internal/git/localrepo/tree_test.go for implementation tests.

See https://gitlab.com/gitlab-org/gitaly/-/blob/master/internal/gitaly/service/operations/submodules_test.go for RPC tests.

They are blocking the gitaly release !122338 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports