Skip to content

Add single-redis jobs to coverage dependency

Sylvester Chin requested to merge sc1-add-single-redis-to-coverage into master

What does this MR do and why?

This MR adds single-redis jobs into the dependency list of rspec:coverage. There are code paths that split depending on the type of Redis (Client or Cluster). Excluding single-redis jobs could lead to rspec:undercoverage job failure. An example is https://gitlab.com/gitlab-org/gitlab/-/jobs/4400050026 where there is spec under coverage and adding !121918 (ede8b167) resolved it.

Note that !122421 (ce2b9654) was added to trigger a pipeline with single-redis jobs (https://gitlab.com/gitlab-org/gitlab/-/pipelines/887447907). That commit was undone in !122421 (ead771a5).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sylvester Chin

Merge request reports