Skip to content

Split feature categorization for notes endpoint

Heinrich Lee Yu requested to merge notes-polling-feature-category into master

What does this MR do and why?

Projects::NotesController is used by both issues, merge requests, and other project-level noteables.

This MR moves some of the merge request related requests to code_review_workflow.

How to set up and validate locally

  1. Open a merge request and check the logs with something like:

    tail -f log/development_json.log | jq 'select(."meta.caller_id" == "Projects::NotesController#index") | { path: .path, status: .status, feature_category: ."meta.feature_category" }'

  2. You will see the requests that return 200 will now have the correct code_review_workflow feature category

Note: Etag caching hits that return 304s still fall under the default team_planning category but this should be fine for now as I'm working on moving this feature to websockets and removing etag caching for this action.

To force 200s in the polling, you can "Disable caching" in the network inspector, or create a new note on the MR and the next poll should be a 200.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports