Skip to content

Don't set pagination for recursive tree calls

Vasilii Iakliushin requested to merge 412288_skip_pagination_for_recursive_tree_calls into master

What does this MR do and why?

Contributes to #412288 (closed)

Problem

For recursive calls we use git ls-tree method. It's pretty efficient: gitaly!4052 (merged).

Pagination for it makes little sense. It only can save an HTTP response size. For repeated requests with pagination, we will call git ls-tree again, collect the result, and finally apply the pagination to the result. Pagination doesn't play any role during git ls-tree execution. There is no performance gain from it.

Solution

Don't apply pagination to recursive calls when pagination is missing. Otherwise, API provides no way to access this data.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports