Reduce `GitlabSettings::Options` interface
What does this MR do and why?
The initial work of replacing the SettingsLogic gem by an in-house code had the pitfall of delegating any Hash method to its internals, which led to confusion and bugs. To avoid that, we're reducing the GitlabSettings::Option interface to reduce the number of mutations and provide a more concise experience to contributors.
Related to:
- Google Secure LDAP No implicit conversion of op... (#413017 - closed)
- Remove Settingslogic gem (!113040 - merged)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Kassio Borges